logo
Welcome to our new AbleCommerce forums. As a guest, you may view the information here. To post to this forum, you must have a registered account with us, either as a new user evaluating AbleCommerce or an existing user of the application. For all questions related to the older version of Gold and earlier, please go to AbleCommerce Gold forum. Please use your AbleCommerce username and password to Login. New Registrations are disabled.

Notification

Icon
Error

Options
Go to last post Go to first unread
MaximillianC  
#1 Posted : Friday, March 5, 2021 1:31:12 PM(UTC)
MaximillianC

Rank: Member

Groups: Developers
Joined: 6/4/2020(UTC)
Posts: 16

Thanks: 5 times
I'm not sure if this bug has already been fixed in a subsequent release, but this is a MAJOR issue in 9.0.1, as it can result in customers seeing other customers' order details. Just a single bad line of code in the MembersController PayMyOrderDetails action method causes order info to be loaded passing the Order No as the Order ID (which aren't always the same), resulting in order details from a different order (generally that of another user/customer) to be shown to the user on the Pay My Order screen, whenever the AC order numbers differ from from the order ID. For one of our clients, their order numbers and order IDs were the same until recently, but when they became different a few days ago, their customers started reporting seeing the wrong order info when clicking the Pay Now button.

On a related (but less-severe) note, the _PaymentWidget method in the CheckoutController is also doing something similar, passing the Order ID to the widget view, rather than the Order #, so it shows the wrong Order # on the header in that widget.

I have fixed all of this in our code, so we don't need a fix, but I just wanted to let everyone know, so they can be aware of this potentially-major issue. Let me know if you have any questions.

Regards,

Maximillian R. Carper
Carper Business Automation

Edited by user Friday, March 5, 2021 1:32:34 PM(UTC)  | Reason: Not specified

Wanna join the discussion?! Login to your AbleCommerce Forums forum account. New Registrations are disabled.

shaharyartiwana25816656  
#2 Posted : Monday, March 8, 2021 2:22:03 AM(UTC)
shaharyar

Rank: Advanced Member

Groups: Admin, Developers, Registered, HelpDesk, Authorized User
Joined: 10/5/2018(UTC)
Posts: 704

Thanks: 5 times
Was thanked: 113 time(s) in 112 post(s)
Hi,

I am able to reproduce the issue. I am going to report this as a bug.
Thank you for identifying!

Regards
MaximillianC  
#3 Posted : Monday, March 8, 2021 12:20:38 PM(UTC)
MaximillianC

Rank: Member

Groups: Developers
Joined: 6/4/2020(UTC)
Posts: 16

Thanks: 5 times
Thank you for your quick response and attention to this. Hopefully you proactively notify all 9.0 customers about this, since it's a customer privacy issue, and tell them how to fix it themselves, since (I believe) all customers have access to the problem code, and it's just a few lines to fix it. For those who customize AC a fair amount (as we do for our clients), upgrading to the next version can be a fairly-intense process, so a lot of times, just being able to fix the bugs in our own customized code is a lot easier.

Edited by user Monday, March 8, 2021 12:23:29 PM(UTC)  | Reason: Not specified

Users browsing this topic
Guest
Forum Jump  
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.