Rank: Advanced Member
Groups: HelpDesk, Developers Joined: 11/9/2018(UTC) Posts: 564
Thanks: 122 times Was thanked: 26 time(s) in 25 post(s)
|
I notice in the Sample theme there is a variety of base color style sheets in /Themes/Sample/Content/Colors
But the Sample theme itself seems hardcoded to the dark-blue.css in the /Themes/Samples/Views/Shared/_ThemeStyles.cshml file. Wouldn't it make more sense to have this configurable as a theme setting i.e. "Select Base Color Stylesheet:"? I get that you could copy the theme to a new folder and just change it there. But this being an option would certainly benefit those who simply edit the default theme.
also, I notice that ViewLicenseAgreement and ViewReadMe views are hard-coded to reference the dark-blue.css. So even if you changed it in the base layout file, these two views won't pick up the change.
|
|
|
|
Rank: Administration
Groups: Admin, Administrators, HelpDesk, System, Authorized User, Developers, Registered Joined: 10/5/2018(UTC) Posts: 175
Thanks: 8 times Was thanked: 17 time(s) in 15 post(s)
|
Quote:Wouldn't it make more sense to have this configurable as a theme setting i.e. "Select Base Color Stylesheet:"? I get that you could copy the theme to a new folder and just change it there. But this being an option would certainly benefit those who simply edit the default theme.
Yes, it would. What you are pointing too is basically allowing multiple skins within a theme. At the moment you need to manually change the file to switch the skin. Quote:also, I notice that ViewLicenseAgreement and ViewReadMe views are hard-coded to reference the dark-blue.css. So even if you changed it in the base layout file, these two views won't pick up the change. Thanks for the information. I just reported this in our logs. Edited by user Thursday, November 7, 2019 4:30:28 AM(UTC)
| Reason: Not specified
|
1 user thanked mazhar for this useful post.
|
|
|
Forum Jump
You cannot post new topics in this forum.
You cannot reply to topics in this forum.
You cannot delete your posts in this forum.
You cannot edit your posts in this forum.
You cannot create polls in this forum.
You cannot vote in polls in this forum.
Important Information:
The AbleCommerce Forums uses cookies. By continuing to browse this site, you are agreeing to our use of cookies.
More Details
Close